-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of ios push notifications #746
Conversation
kunall17
commented
Jun 26, 2017
- Currently untested, due to some issues of apns certificate on chat.zulip.org (Will be resolved soon)
- Not sure if Bundle ID should be the same as the certificate ID, but a provisioning team needs to be create to test this on a device
- The displaying content part of the notification is mostly related from the server (unlike GCM), hence a PR will be landing there.
Automated message from Dropbox CLA bot @kunall17, it looks like you've already signed the Dropbox CLA. Thanks! |
At a first glance the code looks ok. I'll do a more thorough review and merge if OK. |
Heads up @kunall17, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Rebase and try to test and improve the code and prepare it for the server with a certificate. Likely we will have it very soon and then it will be highest priority to make it work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1ae9d50
to
98a3f3c
Compare
Make sure tests pass. |
Done |
Nice. Getting it in. |